search

zorkian / go-datadog-api

A Go implementation of the Datadog API.
BSD 3-Clause "New" or "Revised" License
183 stars 156 forks source link

Add additional arguments to Downtime struct #227

Closed vanvlack closed 5 years ago

vanvlack commented 5 years ago

re: #226

Adds additional arguments to the Downtime struct

vanvlack commented 5 years ago

@ojongerius do you have a chance for review?

bkabrda commented 5 years ago

@vanvlack hey, is there any reason why there are no getters/setters for Downtime.MonitorTags? This PR looks great otherwise BTW!

vanvlack commented 5 years ago

is there any reason why there are no getters/setters for Downtime.MonitorTags

Unsure, will try to regenerate the get/set stuff and see what happens.

vanvlack commented 5 years ago

@bkabrda by the looks, no arrays (even ones elsewhere) are in the generated get/set file.

bkabrda commented 5 years ago

@vanvlack ah, right, the getters and setters are only generated for struct members that are pointers, so everything is correct in this case.

bkabrda commented 5 years ago

Hey @vanvlack if you could address comments from @ojongerius and rebase, that would be awesome and also allow me to merge this PR.

vanvlack commented 5 years ago

@bkabrda updated

bkabrda commented 5 years ago

Ok, the tests are passing and all comments that @ojongerius made were addressed. LGTM, merging. Thanks a lot for the PR!