search

zorkian / go-datadog-api

A Go implementation of the Datadog API.
BSD 3-Clause "New" or "Revised" License
183 stars 156 forks source link

[slos] fix API payloads #252

Closed platinummonkey closed 5 years ago

platinummonkey commented 5 years ago

We changed the name of this the threshold slo property to target as it's more meaningful. The hardest part of SW - naming.

Also updated the content types of create and added request validation as well.

bkabrda commented 5 years ago

The recent changes have removed the createSLOThreshold and createUpdateServiceLevelObjective, but (some of) the accessors for these remained in the autogenerated accessors file for these, so the compilation fails. Could you please remove these so I can test and merge? Thanks!

platinummonkey commented 5 years ago

yup! I'm waiting for us to merge && deploy the final API changes before continuing this work 👌

bkabrda commented 5 years ago

@platinummonkey ok, feel free to ping me whenever this is ready to be re-reviewed.

platinummonkey commented 5 years ago

@bkabrda good to go 👍 

--- PASS: TestServiceLevelObjectivesCreateGetUpdateAndDelete (3.84s)
PASS
bkabrda commented 5 years ago

LGTM now, merging. Thanks!