zorkian / go-datadog-api

A Go implementation of the Datadog API.
BSD 3-Clause "New" or "Revised" License
183 stars 156 forks source link

Added support for tags_execution property #303

Closed carlosperello closed 4 years ago

carlosperello commented 4 years ago

This PR adds support for tags_execution field on event_stream and event_timeline widgets. The field is either or or an and and controls how the tags are handled in the query string.

I didn't find that field documented on datadog site, however the field is there when you query it using the API and it has or or and depending on what you typed on the query string with multiple tags.

This is need to fix https://github.com/terraform-providers/terraform-provider-datadog/issues/398

bkabrda commented 4 years ago

Hey 👋 the code LGTM, but you'll need to run make generate once more and commit the results of that to make CI pass. I can merge when that's done. Thanks!

bkabrda commented 4 years ago

Merging. Thanks a lot for opening the PR!

carlosperello commented 4 years ago

Thanks for review and merging it. Sorry, forgot to comment when I pushed latest changes, got distracted by something else :angel: