search

zorkian / go-datadog-api

A Go implementation of the Datadog API.
BSD 3-Clause "New" or "Revised" License
183 stars 156 forks source link

Change ServiceLevelObjectiveHistory Uptime to SliValue #306

Closed t-sato closed 4 years ago

t-sato commented 4 years ago

It seems that the uptime of SLO history API was changed to sli_value.

## Monitor Based
{
  "data": {
  ...
    "overall": {
      "sli_value": 99.04629516601562,
  ...
  "groups": [
      {
        "sli_value": 99.68518829345703,
        ...
      }
  ]
}
## Event Based
{
  "data": {
    ...
    "overall": {
      "sli_value": 100,
      ...
    }
    ...
  }
}

API doc: https://docs.datadoghq.com/api/?lang=bash#get-an-slo-s-history This PR changes the value of ServiceLevelObjectiveHistory structs from uptime to sli_value.

bkabrda commented 4 years ago

LGTM, merging. Thanks for the contribution!