search

zorkian / go-datadog-api

A Go implementation of the Datadog API.
BSD 3-Clause "New" or "Revised" License
183 stars 156 forks source link

Fix go regression in json.Number unmarshalling #312

Closed bkabrda closed 4 years ago

bkabrda commented 4 years ago

This PR fixes regression in unmarshalling of json.Number in Go 1.14 as noted at [1]. In short, the value "auto" that used to be unmarshalled properly for json.Number is now considered an error.

I went through the other places where we use json.Number and it doesn't seem they're affected.

[1] https://golang.org/doc/go1.14#encoding/json

bkabrda commented 4 years ago

Thanks for the reviews, merging.