search

zorkian / go-datadog-api

A Go implementation of the Datadog API.
BSD 3-Clause "New" or "Revised" License
183 stars 156 forks source link

Add Indexes array to Log Stream Widget #318

Closed kgrodzicki closed 4 years ago

kgrodzicki commented 4 years ago

add: Indexes array to LogStreamDefinition(board_widgets.go) and Widget(screen_widgets.go). Update integration test.

According to https://docs.datadoghq.com/dashboards/widgets/log_stream/ logset is Deprecated and indexes should be used. #317

jirikuncar commented 4 years ago

@kgrodzicki why have you reverted the make generate from 4436be3 in f58d2bd?

kgrodzicki commented 4 years ago

Thank you for the PR! Can you please resolve conflicts and update the tests? 🙇

@jirikuncar thanks for help with this PR! Have fixed the conflicts, updated tests and rebased commits on top fo the master 🚀

kgrodzicki commented 4 years ago

@kgrodzicki why have you reverted the make generate from 4436be3 in f58d2bd?

@jirikuncar During merge I did change the type for Indexes in screen_widgets.go 5ff5240 from string to []string. In that case the make generate does not generate accessors any more 😅