search

zorkind / Hellion-Rescue-Project

54 stars 7 forks source link

Straight Line "Orbits" (trajectory) #240

Open CheeseJedi opened 4 years ago

CheeseJedi commented 4 years ago

Issue present in: Vanilla (and almost certainly HRP)

Client Version: Current, several previous builds.

Describe the bug: Hellion's handling of Sphere-Of-Influence transfers broke some time back.

If you are in a moon's SOI, and use thrusters (or otherwise apply force to a vessel) that means it exits the moon's SOI and enter's the parent bodies (or any other SOI for that matter), the orbital parameters for the vessel go down the toilet and the vessel's orbit is displayed as more-or-less a straight line in the nav map.

I noticed that this is usually accompanied by a negative apoapsis value - not something that's usually valid for a Keplerian description of an orbit. From Wikipedia, for reference **

apoapsis ăp″ō-ăp′sĭs n. The point at which an orbiting object is farthest away from the centre of mass of the body it is orbiting. **

Once in a broken 'straight line orbit' it is generally possible to warp away from it, but it's not normally possible to warp back to it.

Expected behavior: Changing SOI (via any method) should not result in a 'broken'/inconsistent orbit.

Screenshots: 588210_screenshots_20181123152113_1

Additional context: A ship at warp has it's orbital parameters constantly updated in flight. Crossing an SOI boundary triggers this issue, however the only reason that the game is still playable is that the warp mechanic specifically had a workaround for this issue - I suspect in this case it simply overwrites the badly calculated values with what you'd originally asked for when the warp manoeuvre ends.

Sadly this 'hack' won't work for thruster (or other) based SOI transfers as the 'target' orbit cannot be known by the game in advance.

Getting to the underlying cause would solve a problem that has been quite widely reported. It can be particularly frustrating if it's your whole base that drifted in to one of these dodgy 'orbits', as you can't return to it. 🤞

zorkind commented 4 years ago

Hey man, would you mind fitting the tickets into one of our templates? it is easier for me to go through them when they are in 1 single format.

I hope you understand, also i agree about the 1 line orbits bug i was going to do something about them at some point, nice of you to report tho, appreciate it :)

CheeseJedi commented 4 years ago

No worries - Updated, and I managed to find a screenshot of the issue as well! (taken December 2018)

zorkind commented 4 years ago

Good deal, thanks !