zorn-v / nextcloud-social-login

GNU Affero General Public License v3.0
199 stars 138 forks source link

OAuth2 - Can not get identifier from provider #304

Open zorn-v opened 2 years ago

zorn-v commented 2 years ago

First of all, oauth2 does not have some "standardized" fields. Everyone invent his own format. I does not want to include it in my plugin because of this, but decided to see what would happen.

First, try to figure out is your provider supports OIDC (OpenID connect). If it is - use it instead oauth2. It have "standardized" fields and you should not have problems.

If you really wan't that provider and it not have OIDC, try to do something like described here https://github.com/zorn-v/nextcloud-social-login/issues/268#issuecomment-847263180 and create issue like "OAuth2 provider identifier" with response body (with cleared sensitive data if exists). I'll add it as possible.

Requests with "make identifier field configurable" will be closed. Misconfigured field can make "login by another user" issue. Discussed many times.