search

zorn-v / nextcloud-social-login

GNU Affero General Public License v3.0
198 stars 137 forks source link

Add name field #319

Closed marcantoinegodde closed 2 years ago

marcantoinegodde commented 2 years ago

This PR adds the possibility to decide which field to use to define user's name.

zorn-v commented 2 years ago

First of all, I respect your doings. But :) $response->$nameField; will give undefined blablabla if there is no such "field" in response. Also, why personal.js was changed ? I suppose you have other version of nodejs than me (or even node_modules). And because of this I do not welcome compiled js in pull requests.

Anyway, https://github.com/zorn-v/nextcloud-social-login/commit/9499995cdf9d8509c196077610decb531ea86c25

zorn-v commented 2 years ago

Anyway, 9499995

Damn, looks like mined hash :smile:

marcantoinegodde commented 2 years ago

Thank you anyway for having considered my proposal. You'll help many of us. :)