Closed p-bo closed 1 year ago
What point of such "overcomplicate"
and gain benefits
Which benefits ?
For instance:
To conclude: with continuous translation workflow, result is, that users of your app are getting more complete and more polished localization, so their user experience is much more pleasant.
Helped this to better understanding, how this one-time effort would continuously improved your app without any future work for you please?
I rephrase the question: why I should depend on some external service ? Without any benefits. L10n is for beauty, not for work.
It is recommended way by Nextcloud developers. See https://nextcloud.com/contribute/ Help translate Nextcloud. there.
And there is no unavoidable dependency - it is just additional (and as stated, very efficient one) - it is still possible to contribute translation in direct git edit way as is used now.
Benefit of L10n is to make easier/possible to use apps even for people, who don't understand English (enough). It is understandable, that from point of view of software developer, who must be proficient in English from principle, it is hard to have empathy for people who are not...
And it shouldn't take much time of your time - just open issue on https://github.com/nextcloud/docker-ci/issues/new/choose (choose Request translations). There you will get checklist of only few things to do as for example this: https://github.com/nextcloud/docker-ci/issues/426 and you can ask rakekniven if something is unclear to you. Hope it helps :-)
For motivation: This developer also at first was not so fond of this approach, than he agreed to try and at the end, was very pleased with result! :-)
Done
That's great! - many thanks for this improvement for users of your app and Nextcloud (and translators too ;-) ) :-)
it is still possible to contribute translation in direct git edit way as is used now.
This is not true - bot just erase those changes. You totally lose control of l10n with it. For example it remove ja_JP translation completely, and I cannot to restore it in transifex because does not member of "Japan" team.
Foremost, very sorry for giving wrong information - was really under impression it is working that way. But for recipients of translation (users) is situation much improved. Analysing and comparing state just before continuous translation workflow deployed - https://github.com/zorn-v/nextcloud-social-login/blob/395349a26c059749aa3ef68eb7e79efac133a6e4/l10n and after:
looking at current progress of translations https://www.transifex.com/nextcloud/nextcloud/sociallogin/
And as bonus - new, before not existent translations:
And situation will become even much better in coming weeks - see example of another recently added (to continuous localization workflow):
Does this all, at least partly, improving your feeling regarding this please?
even .js and .json files of the same language contained different number of strings to translate
Because it is enough. json
- for php strings ($l->t('Translable php string')
) and js
for js
(t('appname', 'Translable js string')
). Bot just throws everything into a pile without taking care of it.
BTW, you also need to adapt sources like https://github.com/zorn-v/nextcloud-social-login/commit/82e22aac11e662346c1bc1a9611fe91bb8b593a1 and https://github.com/zorn-v/nextcloud-social-login/commit/585a5d9eb452efab2557d0a21555d3f19dc3a871 I wait now for next sync to check is everything ok now.
de - previously stub, now complete => win ...
Actually not, there is not all string in transifex now :wink:
Does this all, at least partly, improving your feeling regarding this please?
Does not decided yet
Thanks again for all that your work (lot of commits) here to adapt source code of app for Nextcloud bot / Transifex workflow and also work done on infrastructure of bot itself (https://github.com/nextcloud/docker-ci/pull/458) - appreciated!
Hello, would it be possible to follow instructions on: https://docs.nextcloud.com/server/latest/developer_manual/basics/front-end/l10n.html#adding-translations ...and gain benefits from work of whole Nextcloud translators community for users of your app please?
Thanks :-)