zorn-v / nextcloud-social-login

GNU Affero General Public License v3.0
198 stars 137 forks source link

Conditions around "can be relative to base URL" aren't clear #403

Open goetzk opened 1 year ago

goetzk commented 1 year ago

When specifying an API Base URL and using relative urls in Authorize url (and others) there is no warning if base URL isn't used. It appears the code checks for a leading slash on Authorize url and others and will only join base url if present.

This means if you happen to assume the url will be assembled by inserting / between the values or simply miss the leading / when you paste in the urls service failure will be effectively silent.

It would be great if the page could be changed to either

thanks,