search

zorn-v / xmpp

Library for XMPP protocol connections (Jabber) for PHP
Other
9 stars 2 forks source link

Unterminated entity reference #6

Open srms-fr opened 4 months ago

srms-fr commented 4 months ago

Hi,

Could you look about this one : 

[2024-04-12T11:30:18.129137+02:00] xmpp.DEBUG: Received buffer '<presence from='user/jabber_13405' to='test@domain.com' xml:lang='en'><priority>5</priority><x var='128' xmlns='http://webex.com/connect/customstatus'/><systemstatuschange xmlns='urn:xmpp:systemstatuschange'/><c hash='sha-1' node='http://protocols.cisco.com/jabber?v=14.1.4&amp;p=win' ver='XekFR/TSudu/1muDk2LJS/aBBFg=' xmlns='http://jabber.org/protocol/caps'/></presence>' from 'tcp://xmpp.domain.com:5222' [] []
PHP Warning:  Fabiang\Xmpp\Stream\XMLStream::createAttributeNodes(): unterminated entity reference           p=win in /.../vendor/zorn-v/xmpp/src/Stream/XMLStream.php on line 283

I'm not shure, but value of a DOMAttr seems to need to be protected by htmlentities().

Thanks

zorn-v commented 4 months ago

Fixed in v1.0.1 https://github.com/zorn-v/xmpp/commit/c49e4d105816d294224658f73bf79147e49d4a1e