zorzella / guiceberry

Leverage Guice to achieve Dependency Injection on your JUnit tests
Apache License 2.0
28 stars 13 forks source link

Upgrade junit to junit 4.11 #28

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
The version of junit currently used by guiceberry is a very bad one to be using 
because it bundles the hamcrest library inside of it. This can cause issues for 
folks who include hamcrest in their own project and then have the duplicate 
classes collide. junit 4.11 does not have this problem.

Original issue reported on code.google.com by benjamin...@gmail.com on 5 Jun 2013 at 7:38

GoogleCodeExporter commented 9 years ago
Would love to see guiceberry use a version of junit that isn't three years old!

Original comment by benjamin...@gmail.com on 27 Sep 2013 at 7:40

GoogleCodeExporter commented 9 years ago
Would you be willing to make me a project maintainer? I would be happy to fix 
this issue. This project seems to be on the backburner, so it would be great to 
get some fresh blood involved even if you'd rather choose someone other than 
myself to help out.

Original comment by benjamin...@gmail.com on 12 Feb 2014 at 8:01

GoogleCodeExporter commented 9 years ago
ping

Original comment by benjamin...@gmail.com on 14 Jun 2014 at 1:19

GoogleCodeExporter commented 9 years ago
My deepest apologies. I have not been able to give as much time as it's needed 
here. Let's start with fixing this bug. I believe this should do what you are 
asking for:

https://code.google.com/p/guiceberry/source/detail?r=289

Let me know it looks good and I'll cut the release, though I'll first try to 
address issues 27 and 26 as well.

Original comment by zorze...@gmail.com on 16 Jun 2014 at 8:33

GoogleCodeExporter commented 9 years ago
Awesome. Thanks!

Original comment by benjamin...@gmail.com on 16 Jun 2014 at 9:03

GoogleCodeExporter commented 9 years ago
You can close this issue now since it has been fixed

Original comment by benjamin...@gmail.com on 12 Feb 2015 at 9:29