search

zotero / citeproc-rs

CSL processor in Rust.
https://cormacrelf.github.io/citeproc-wasm-demo/
Other
75 stars 11 forks source link

Integration testing on Zotero's Firefox ESR #108

Closed cormacrelf closed 3 years ago

cormacrelf commented 3 years ago

This fixes #84 again. Upstream wasm_bindgen@0.2.70 added a shim to avoid using mutable globals altogether, so it has been upgraded and the workarounds removed. This also means wasm-opt is back! Yay, binaries will be ever so slightly smaller again.

I wanted to be sure this wouldn't happen again, so I added an integration test using the exact version of Firefox ESR Zotero uses to GitHub CI to make sure everything runs there. As in, fetches zotero-standalone-build, uses the script to download Firefox, and uses selenium-webdriver to load up a test page and wait for it to write a success value into the DOM. It will break if fetch_xulrunner.sh is changed too much, but that's OK, I assume if that's happening then there will be some other good things happening to balance it out :)

Instructions in the js-tests README.md if you wish to to try it yourself. Caveats: may leave zombie Firefox processes lying around on your system. 60.9 is oooold, selenium is kinda shaky at killing it.

dstillman commented 3 years ago

This is great — thanks for setting this up. (Hopefully we'll make it obsolete…soon?)