search

zotero / citeproc-rs

CSL processor in Rust.
https://cormacrelf.github.io/citeproc-wasm-demo/
Other
73 stars 11 forks source link

reimplement name parsing #139

Closed cormacrelf closed 2 years ago

cormacrelf commented 2 years ago

This used to use code from citeproc-js, licensed under the Common Public Attribution License, so compliant users of citeproc-rs had to credit Frank, for the small amount of code here and nothing else. It's been a year or two since I've been over it, so I deleted the parts I took, and wrote it again from first principles. It turned out a little bit simpler in general, using just straight ^ and $-based regexes with repetition for given names and last names, rather than the one-particle-at-a-time + given-names-get-reversed strategy of Frank's version.

Also adds support for the using strings and numbers as fuzzy JS-style booleans on the static-particles JSON input.

fbennett commented 2 years ago

(For what it's worth, I wouldn't have cared about licensing whatnot whatnot.)

cormacrelf commented 2 years ago

I didn't think you would have, but people (esp. companies) get antsy about the littlest things when they're considering whether to use an open source work. And easier to just write it again than kick up a fuss :)

fbennett commented 2 years ago

All righty then.

On Thu, Dec 2, 2021, 22:00 Cormac Relf @.***> wrote:

I didn't think you would have, but people (esp. companies) get antsy about the littlest things when they're considering whether to use an open source work. And easier to just write it again than kick up a fuss :)

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/zotero/citeproc-rs/pull/139#issuecomment-984606410, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAASMSSHXUIYUKMSC7AS4ZLUO5UXXANCNFSM5JENKXKQ . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.