cormacrelf
commented
4 years ago Ok, unreachable in this case isn’t an unreachable!() call, it’s just that this build executes WASM’s unreachable instruction when it panics, so you don’t get to see the panic message. An even better report would be attained with --features console.
However, in this case, it is almost certainly this line:
panic!("called cite_position on unknown cite id, {:?}", key);In this case, UpdateSummary::summarize() is requesting a built cluster for a cluster that isn’t in the document. Why? Because you called builtCluster manually, without calling drain() afterwards, so the processor considers this to be one of the “touched” clusters that needs to be reported as a change; it got added to the update queue. Filtering out any clusters in the queue that shouldn’t be included would fix this, but you should still make sure you call drain() to get optimally small updates. PR incoming to fix and to document better.
Perhaps a better API for that use case would be only “give me every cluster and then drain the update queue, consider this point to be client and processor in sync”, although it would be a bit limiting.
adomasven
Zotero debug log
``` (5)(+0000004): CiteprocRs: new Driver (5)(+0000001): CiteprocRs: new Driver (5)(+0000008): CiteprocRs: setClusterOrder [] (3)(+0000000): CiteprocRs: updateUncitedItems not available in citeprocRs (5)(+0000484): CiteprocRs: insertReference {"id":"1301","type":"chapter","abstract":"When John A. Hannah announced his retirement as president of Michigan State University to become Director of the U.S. Agency for International Development, it marked the end of an era. For twenty-eight years, he had done all the things which Clark Kerr says a university president must do; he was a “friend of the students, a colleague to the faculty, a good fellow with the alumni, a sound administrator with the trustees, a good speaker with the public, an astute bargainer with the foundations and the federal agencies, a politician with the state legislature, a friend of industry, labor, and","container-title":"The Test","ISBN":"978-0-87013-648-1","page":"17-32","publisher":"Michigan State University Press","source":"JSTOR","title":"THE STAGE IS SET","URL":"http://www.jstor.org/stable/10.14321/j.ctt130hjnp.5","editor":[{"family":"ADAMS","given":"WALTER"}],"accessed":{"date-parts":[["2017",10,20]]},"issued":{"date-parts":[["2003"]]}} (5)(+0000001): CiteprocRs: insertCluster {"id":1,"cites":[{"id":"1301"}]} (5)(+0000000): CiteprocRs: setClusterOrder [{"id":1}] (5)(+0000000): CiteprocRs: builtCluster 1 (5)(+0000002): CiteprocRs: insertReference {"id":"1301","type":"chapter","abstract":"When John A. Hannah announced his retirement as president of Michigan State University to become Director of the U.S. Agency for International Development, it marked the end of an era. For twenty-eight years, he had done all the things which Clark Kerr says a university president must do; he was a “friend of the students, a colleague to the faculty, a good fellow with the alumni, a sound administrator with the trustees, a good speaker with the public, an astute bargainer with the foundations and the federal agencies, a politician with the state legislature, a friend of industry, labor, and","container-title":"The Test","ISBN":"978-0-87013-648-1","page":"17-32","publisher":"Michigan State University Press","source":"JSTOR","title":"THE STAGE IS SET","URL":"http://www.jstor.org/stable/10.14321/j.ctt130hjnp.5","editor":[{"family":"ADAMS","given":"WALTER"}],"accessed":{"date-parts":[["2017",10,20]]},"issued":{"date-parts":[["2003"]]}} (5)(+0000001): CiteprocRs: insertCluster {"id":2,"cites":[{"id":"1301"}]} (5)(+0000000): CiteprocRs: setClusterOrder [{"id":2}] (3)(+0000000): CiteprocRs: batchedUpdates zotero(3)(+0000003): RuntimeError: unreachable executed __rust_start_panic@resource://zotero/loader.jsm -> resource://zotero/citeproc-rs.js:2838407:1 rust_panic@resource://zotero/loader.jsm -> resource://zotero/citeproc-rs.js:2829322:1 std::panicking::rust_panic_with_hook::h5e7c2dc110ae79d4@resource://zotero/loader.jsm -> resource://zotero/citeproc-rs.js:2631309:1 std::panicking::continue_panic_fmt::hb5b3e4b5160fe2ab@resource://zotero/loader.jsm -> resource://zotero/citeproc-rs.js:2784297:1 std::panicking::begin_panic_fmt::h62d8474306d91923@resource://zotero/loader.jsm -> resource://zotero/citeproc-rs.js:2806028:1Attached above is the debug log for the full set of operations before the error is reached.