Our quote styles have become very inconsistent - a lot of older code uses double quotes, newer-ish code uses single quotes, and some recent code (especially CE code) uses both. This sets the quote style to single everywhere and enforces it as an ESLint error. Maybe controversial but I think it's for the greater good!
We'd want to follow this up with a cleanup commit in zotero/zotero (ESLint can do that automatically), which we could add to .git-blame-ignore-revs so blames stay clean.
If a file (e.g. a direct port of Mozilla code) needs to consistently use double quotes instead, it can have an /* eslint quotes: ["error", "double"] */ comment at the top.
This would've caused an error before:
Happens all over the place in zotero/zotero.
Our quote styles have become very inconsistent - a lot of older code uses double quotes, newer-ish code uses single quotes, and some recent code (especially CE code) uses both. This sets the quote style to single everywhere and enforces it as an ESLint error. Maybe controversial but I think it's for the greater good!
We'd want to follow this up with a cleanup commit in zotero/zotero (ESLint can do that automatically), which we could add to
.git-blame-ignore-revs
so blames stay clean.If a file (e.g. a direct port of Mozilla code) needs to consistently use double quotes instead, it can have an
/* eslint quotes: ["error", "double"] */
comment at the top.