zotero / reader

PDF/EPUB/HTML reader for Zotero
Other
129 stars 30 forks source link

EPUB appearance: Add 'Use original font' and 'Page width' options, increase zoom limit #132

Closed AbeJellinek closed 3 months ago

AbeJellinek commented 3 months ago

Looks like this:

image

If we had some "narrow"/"normal"/"full" icons, we could use them for the page width slider, but I don't think that's essential, and a textual label felt like overkill.

Addresses zotero/zotero#4456 and zotero/zotero#4457

yexingsha commented 3 months ago

When I try to build this it keeps throwing npm error, but from the screenshot it looks fine. I think putting icons here while all other sliders use text labels might be weird. I'm not sure how page width is calculated, but what if we just display a percentage, so that the widest is 100% and the narrowest is e.g. 50%?

AbeJellinek commented 3 months ago

Full is just unlimited, so however wide the window is, that's how wide the page will be (minus text margins).

AbeJellinek commented 3 months ago

But percentages seem fine - doesn't really have to be exact, but it gets the point across.

AbeJellinek commented 3 months ago

@dstillman: OK to merge? I can add the strings in zotero/zotero before updating submodules.

dstillman commented 3 months ago

Merged