search

zotero / scaffold

Zotero translator creation IDE
http://www.zotero.org/support/dev/scaffold
38 stars 9 forks source link

Replace ace with source-editor.jsm #11

Closed simonster closed 6 years ago

simonster commented 12 years ago

Firefox 11 and later include a built-in source editor. We should use this instead of ace.

rmzelle commented 9 years ago

That link says "This component has been removed from the platform in Firefox 28."

Looks like Firefox uses the CodeMirror code editor now: https://github.com/JasonBarnabe/stylish/issues/141

rmzelle commented 9 years ago

See also https://developer.mozilla.org/en-US/docs/Tools/Editor

rmzelle commented 9 years ago

I tried invoking the build-in CodeMirror, using https://github.com/JasonBarnabe/stylish/commit/96f0d96aa73226d463e7187475f567f8881d292a and the above link as guidance, but I couldn't get a CodeMirror editor window to render in Scaffold. @aurimasv, do you have some time to look at this?

Once that part works, it looks like the rest of the required code changes (mostly I/O to the editor windows) should be within my reach. (I would like to use CodeMirror for the Zotero Reference Test pane as well, FWIW)

aurimasv commented 9 years ago

Do you want to start a pull request (or just a branch on your fork of Scaffold) with the changes you have now and we can work up from there? (to be perfectly honest, I'm feeling a bit lazy and would rather debug your code than write it up from scratch)

rmzelle commented 9 years ago

It's rather unfamiliar territory for me, so I didn't get very far.

It looks like Ace is initialized at https://github.com/zotero/scaffold/blob/master/chrome/content/scaffold/aceWrapper.js#L40 (and via https://github.com/zotero/scaffold/blob/master/chrome/content/scaffold/scaffold.js#L102 ?)

I also found iframes that call to the Ace library in scaffold.xul. E.g. https://github.com/zotero/scaffold/blob/master/chrome/content/scaffold/scaffold.xul#L130 unescapes to:

<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN" "http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
   <head>
      <script type="text/javascript" src="chrome://scaffold/content/ace/ace.js"></script>
      <script type="text/javascript" src="chrome://scaffold/content/ace/mode-javascript.js"></script>
      <script type="text/javascript" src="chrome://scaffold/content/aceWrapper.js"></script>
   </head>
   <body id="body"></body>
</html>
avram commented 9 years ago

Sorry for the state of the Ace integration-- it was a bit of a hack and I knew nothing about XUL or Ace.

rmzelle commented 9 years ago

Any chance you can take a look, @avram? :)

The benefit of switching to CodeMirror is arguably relatively minor for scaffold, but I was hoping to use it as a template for using CodeMirror in the Zotero Reference Test pane, which currently just has a text field, and where we probably wouldn't want to add a dependency for Ace.

aurimasv commented 9 years ago

There are actually good reasons to do it for Scaffold (e.g. incorporating a debugger into scaffold, adding auto-completion, which may be possible through ace, but I feel like CodeMirror would be easier, because Firefox has done most of the work for us) and I've been looking into it a little bit. It's just not at the top of the list for me right now, but I would gladly support any such efforts. On Jan 10, 2015 1:39 PM, "Rintze M. Zelle" notifications@github.com wrote:

Any chance you can take a look, @avram https://github.com/avram? :)

The benefit of switching to CodeMirror is arguably relatively minor for scaffold, but I was hoping to use it as a template for using CodeMirror in the Zotero Reference Test pane, which currently just has a text field, and where we probably wouldn't want to add a dependency for Ace.

— Reply to this email directly or view it on GitHub https://github.com/zotero/scaffold/issues/11#issuecomment-69468848.

dstillman commented 8 years ago

Any further thoughts on this? One way or another we'll want to switch to unminified files before submitting the XPI for signing to avoid hearing from Mozilla later, and right now all the ACE files are minified.

rmzelle commented 8 years ago

Any further thoughts on this?

It might still be worthwhile to replace ACE with the CodeMirror editor included in Firefox (and use it for csledit.xul as well). I still can't figure out how to load the Firefox editor, though. If I use the instructions at https://developer.mozilla.org/en-US/docs/Tools/Editor let Editor = require("devtools/sourceeditor/editor"); in Zotero_CSL_Editor.init in csledit.js, I get the error JavaScript error: chrome://zotero/content/tools/csledit.js, line 31: ReferenceError: require is not defined.

I figured I might have to do something like Components.utils.import("resource:///modules/devtools/sourceeditor/editor.js"); , but that gave the error JavaScript error: resource:///modules/devtools/sourceeditor/editor.js, line 9: ReferenceError: require is not defined

PS. I just found https://github.com/nt1m/devtools-prototyper/search?utf8=%E2%9C%93&q=sourceeditor, which seems to use the CodeMirror editor.

zuphilip commented 6 years ago

We activated JSLinter, Search and Replace feature in ACE and are working on the Autocompletion. It does not seem to be necessary anymore to switch away from ACE.