zotero / scaffold

Zotero translator creation IDE
http://www.zotero.org/support/dev/scaffold
38 stars 9 forks source link

Show URL of active tab #19

Closed rmzelle closed 9 years ago

rmzelle commented 9 years ago

Pull request for #18.

I found some relevant documentation on XUL events at

but it looks like things already work with the "pageshow" and "TabSelect" events that were already implemented for the _updateFrames function.

rmzelle commented 9 years ago

By the way, this is rather unrelated, but I get the following separate errors in the terminal after running Scaffold for a while (!):

JavaScript error: chrome://scaffold/content/scaffold.xul, line 1: Scaffold.close is not a function
System JS : ERROR chrome://scaffold/content/scaffold.js:1111 - TypeError: menulist.removeAllItems is not a function
rmzelle commented 9 years ago

It looks like:

screen shot 2015-01-11 at 14 46 14

rmzelle commented 9 years ago

@aurimasv, can you review/merge this?

aurimasv commented 9 years ago

Yup, will do. Since Scaffold is currently broken on Fx35, I'll push an update some time today.

rmzelle commented 9 years ago

Also, unrelated: I tried to have Scaffold automatically select the first matching translator in the load window (since that's usually what you want to work on anyway), but I couldn't get it to work properly. I could select an entry in the itemlist, but it wouldn't highlight. If you clicked on the selected entry it would stay unhighlighted as well. I found a website claiming that Firefox's itemlist implementation was rather buggy, and that richitemlist was more robust, but I didn't explore that option.

rmzelle commented 9 years ago

Thanks!