zotero / scaffold

Zotero translator creation IDE
http://www.zotero.org/support/dev/scaffold
38 stars 9 forks source link

Regexp fail under FF46 #30

Closed fbennett closed 8 years ago

fbennett commented 8 years ago

In Firefox 46, I'm getting this error when opening a translator in Scaffold, with empty content under all tabs:

TypeError: m is null

The error comes from lines 196-198 of scaffold.js:

var m = /^\s*{[\S\s]*?}\s*?[\r\n]+/.exec(header);
// Detect the minified framework and strip it
var usesFW = (translator.code.substr(m[0].length).indexOf("/* FW LINE ") !== -1);

Not sure why that would fail. Has the meaning of \S changed? Or maybe I'm missing something else.

zuphilip commented 8 years ago

Can you copy the code of your translator with empty content here?

fbennett commented 8 years ago

Sorry, false alarm. I had tested in Juris-M before merging the latest changes to Zotero. It works fine with an updated client.