search

zotero / scaffold

Zotero translator creation IDE
http://www.zotero.org/support/dev/scaffold
38 stars 9 forks source link

Create new release #42

Closed zuphilip closed 6 years ago

zuphilip commented 6 years ago

https://github.com/zotero/scaffold/releases

zuphilip commented 6 years ago

Maybe now would be a good time to create a new release, as also @adam3smith pointed out...

adam3smith commented 6 years ago

Turns out I have push access. Done

dstillman commented 6 years ago

You actually created it with the wrong tag (v.3.3.0 instead of v3.3.0). Can you move the release notes and XPI to the v3.3.0 tag I created?

adam3smith commented 6 years ago

ugh, sorry about that. done

zuphilip commented 6 years ago

Thank you both!

One thing I didn't understand: What is the reason for the gh-pages branch here? I see that we have thereby https://zotero.github.io/scaffold/scaffold.rdf, but for what is this used?

dstillman commented 6 years ago

It's the update manifest that tells clients (in this case Zotero) about the new version. Referenced from install.rdf.

zuphilip commented 6 years ago

Okay, this step seems missing in the release.sh. Should it be added there?

dstillman commented 6 years ago

Sure. Note that, if you need to use a regexp in the replace line, it's better to use perl rather than sed (similar to our other build scripts), and same for grep — macOS has BSD sed/grep rather than GNU by default, so some of the flags are different. The current script produced empty version values for me because of the grep line.

dstillman commented 6 years ago

And the shasum command can also be different between Cygwin, macOS, and Linux, so you'd want to use this.

zuphilip commented 6 years ago

Okay, thank you for the info. I created an issue about these.