zotero / scaffold

Zotero translator creation IDE
http://www.zotero.org/support/dev/scaffold
38 stars 9 forks source link

Line numbers should not start with 1 #48

Closed zuphilip closed 6 years ago

zuphilip commented 6 years ago

On the first lines of each translator file there is the metadata and therefore the actual code which is shown in Scaffold is usually line 15. If we have these numbers synchronized, then it is much easier to find lines which are mentioned in any debug message.

dstillman commented 6 years ago

https://github.com/zotero/scaffold/issues/49#issuecomment-334962836 also relevant to this

zuphilip commented 6 years ago

There is an option for that in ACE for setting the first line number, i.e. something like

_editors["code"].getSession().setOptions({
    firstLineNumber: 15
});

shoul work. However, it seems that the line numbers in the debug messages and in ACE are only 3 off, but they don't align to the line numbers in the actual translator file. Better alignment of these numbers will also help people using an external editor.

dstillman commented 6 years ago

Fixed in 2f6767d