search

zotero / scaffold

Zotero translator creation IDE
http://www.zotero.org/support/dev/scaffold
38 stars 9 forks source link

set editor firstLineNumber to 15, so that .ci/checkTranslator's resul… #85

Closed mtrojan-ub closed 6 years ago

mtrojan-ub commented 6 years ago

…t matches line number in Scaffold

special wish from @ruschein

adam3smith commented 6 years ago

I seem to have a recollection this has come up before -- I don't think the line 15 is actually exact since the meta head can vary in length and so this wasn't accepted last time (because a "kind of right" is arguably more confusing than a "obviously wrong", but I might be misremembering.

zuphilip commented 6 years ago

We only started to discuss this in #48.

Did you test this changes? There are different places where a line number is reported (testing within scaffold, CI outside, during translation in browser) and I think the offset is not always the same.

zuphilip commented 6 years ago

E.g. within Scaffold on an error 2 is subtracted: https://github.com/zotero/scaffold/blob/79dd06a09106ec0c35798e62596778948ab909c3/src/chrome/content/scaffold/scaffold.js#L506

dstillman commented 6 years ago

Superseded by #91