search

zotero / scaffold

Zotero translator creation IDE
http://www.zotero.org/support/dev/scaffold
38 stars 9 forks source link

Don't try to replace minVersion, maxVersion in release.sh #94

Closed zuphilip closed 6 years ago

zuphilip commented 6 years ago

There are now two minVersion and maxVersion in the install.rdf and therefore the simple perl expressions to replace them if needed, does not work anymore.

However, it seems no problem to do this manually before starting the release script and therefore I just added a prompt in the script.

dstillman commented 6 years ago

I think we can just out the prompt and leave hard-coded min/max versions in install.rdf from now on. I'm not sure if current Zotero even checks version compatibility, and this won't be relevant in the future anyway.

zuphilip commented 6 years ago

Do you mean to "leave out the prompt", i.e. delete it?

dstillman commented 6 years ago

Yes, sorry.

zuphilip commented 6 years ago

Okay, done. Please have a look at the new version.

dstillman commented 6 years ago

Looks good.