search

zotero / styles-repo

Zotero styles page
http://www.zotero.org/styles
14 stars 12 forks source link

Update previews #33

Closed rmzelle closed 8 years ago

rmzelle commented 8 years ago

In response to #32.

Needs to be checked (e.g. by @adam3smith) before merging

rmzelle commented 8 years ago

I removed the newspaper article and patent, added a website (https://www.tesla.com/blog/secret-tesla-motors-master-plan-just-between-you-and-me), and replace the journal article with one that is open access (http://journals.plos.org/plosgenetics/article?id=10.1371/journal.pgen.1002190).

@adam3smith, can you take a look whether the metadata looks good? (in particular the website fields)

rmzelle commented 8 years ago

@adam3smith, bump.

rmzelle commented 8 years ago

I'm wondering if it wouldn't make sense to pick an article with a regular page range

Sure. That eliminates all PLOS journals, though. How about:

An Adaptable Metric Shapes Perceptual Space Hisakata, Rumi et al. Current Biology , Volume 26 , Issue 14 , 1911 - 1915

http://www.cell.com/current-biology/fulltext/S0960-9822(16)30544-9

(journal is subscription-based, but article is open access, has 3 authors, short title, "Current Biology" is short and abbreviates nicely to e.g. "Curr. Biol.", and page range that would even show off page-range-format)

adam3smith commented 8 years ago

that's great, yes. (remember to sentence case the title)

rmzelle commented 8 years ago

I swapped out the journal article. The default Zotero translator import doesn't add an abstract. Do we need it?

rmzelle commented 8 years ago

And the diff is a bit messy because I ran the whole thing through JSON Lint. (the original file had a mishmash of spaces and tabs)

adam3smith commented 8 years ago

Great. I think one abstract (in the website) is enough for the few styles that use the field.

@dstillman this is ready to merge.

dstillman commented 8 years ago

Changes are live

rmzelle commented 8 years ago

Great, thanks.

@adam3smith, I'm not sure if the "Shin’ya Nishida" name renders correctly (seems to show up as "Nishida S ’ya" quite often). @fbennett, do you know if this is a correct contraction for Japanese names? It's this guy: http://www.kecl.ntt.co.jp/people/nishida.shinya/ (from this paper: http://www.cell.com/current-biology/fulltext/S0960-9822(16)30544-9).

adam3smith commented 8 years ago

Apart from the first name contraction (on which I have no insight -- so that may well be fine too) this looks great to me. Thanks!

On Mon, Oct 3, 2016 at 2:08 PM, Rintze M. Zelle notifications@github.com wrote:

Great, thanks.

@adam3smith https://github.com/adam3smith, I'm not sure if the "Shin’ya Nishida" name renders correctly (seems to show up as "Nishida S ’ya" quite often). @fbennett https://github.com/fbennett, do you know if this is a correct contraction for Japanese names? It's this guy: http://www.kecl.ntt.co.jp/people/nishida.shinya/ (from this paper: http://www.cell.com/current-biology/fulltext/S0960-9822(16)30544-9).

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/zotero/styles-repo/pull/33#issuecomment-251180350, or mute the thread https://github.com/notifications/unsubscribe-auth/AAH32i_L6Z7d2sypQJbPbvGWOo8AfIv3ks5qwUSDgaJpZM4KJhJh .

Sebastian Karcher, PhD www.sebastiankarcher.com

rmzelle commented 8 years ago

Also just noticed that all three authors only have one initial, but fortunately the other item types have authors with multiple given names.

fbennett commented 8 years ago

On the short-forming of "Shin'ya" the full-form name is correct. Shinya [しにゃ] and Shin'ya [しんや] are different spellings (the former doesn't exist as a word or name as far as I know). There is a similar pattern of punctuation in romanized Korean, and a colleague in the final phase of PhD editing also reported this as a bug last week. Will be fixed in the processor fairly soon.