Downgrade package-lock file to version 1

zotero / translation-server

A Node.js-based server to run Zotero translators

Other

123 stars 52 forks source link

Downgrade package-lock file to version 1 #129

Closed mvolz closed 3 years ago

mvolz commented 3 years ago

Due to a bug in npm 7, sometimes urls in package-lock "randomly" point to ssh instead of https which causes CI to fail both on github and other platforms, as it can't access to the repository via ssh

Downgrade to npm 6 / use package-lock version 1 until this bug is fixed.

See https://github.com/npm/cli/issues/2610

Change-Id: I4f606bcddcacaa2ee9fb8968057a0fccdbfd7eec

dstillman commented 3 years ago

Thanks — I started to apply a workaround from that thread a month ago but didn't finish looking into it. Seems like this is fixed just by upgrading CI to node 16, which I've done in https://github.com/zotero/translation-server/commit/df953033e8796203344f4ecf13f8e15c77651fd6. (I also applied https://github.com/zotero/translation-server/commit/cd1b01cb93aca5b17f8372219172d73c90ad067d, the workaround from that thread, but it doesn't appear to actually be necessary.) In any case, no need to downgrade.