Closed kerphi closed 5 years ago
I updated the code in connection with your 2 comments.
But currently I noticed the example seams not working as expected:
$ curl -v -d 'https://www.nytimes.com/2018/06/11/technology/net-neutrality-repeal.html' -H 'Content-Type: text/plain' http://127.0.0.1:1969/search
* Trying 127.0.0.1...
* TCP_NODELAY set
* Connected to 127.0.0.1 (127.0.0.1) port 1969 (#0)
> POST /search HTTP/1.1
> Host: 127.0.0.1:1969
> User-Agent: curl/7.58.0
> Accept: */*
> Content-Type: text/plain
> Content-Length: 72
>
* upload completely sent off: 72 out of 72 bytes
< HTTP/1.1 501 Not Implemented
< Content-Type: text/plain; charset=utf-8
< Content-Length: 20
< Date: Thu, 26 Jul 2018 13:31:39 GMT
< Connection: keep-alive
<
* Connection #0 to host 127.0.0.1 left intact
No identifiers found
I've updated the README with the latest instructions, so you'll need to redo the README changes.
You'll want to rebase against master to clear the extra commits above.
Done.
No, that's not right. You need to rebase on top of the latest master. The commit list should be clear except for the changes in this PR.
I'm learning git rebase stuff. I think it's ok now. Could you confirm?
One more question about docker stuff:
do you plan to publish to dockerhub ? as it has been done for the old version https://hub.docker.com/r/zotero/translation-server/ ?
Hello, do you have other comments about this PR?
up ?
There is now a merge conflict with the README.md, which you should fix. CC @dstillman
@zuphilip I fixed the README conflict.
Thank you for fixing the merge conflict. Next steps are up to @dstillman
up, is there a way to merge the PR please?
Thank you!
to be able to use zotero/translation-server-v2 into a docker image/container