search

zotero / translation-server

A Node.js-based server to run Zotero translators
Other
121 stars 50 forks source link

Expose attachments #99

Open wetneb opened 5 years ago

wetneb commented 5 years ago

This is the patch suggested by @noctux in #97. It would be a very useful addition to translation-server, I think.

wetneb commented 5 years ago

Given the test output, I wonder if a better approach would be to embed the attachments as fields of the record, as originally stored in Zotero?

noctux commented 5 years ago

Hey, thanks for doing the pullrequest!

On Sun, Mar 24, 2019 at 11:10:21AM -0700, Antonin Delpeuch wrote:

Given the test output, I wonder if a better approach would be to embed the attachments as fields of the record, as originally stored in Zotero?

As stated in the original issue, the reason for the current format is that I tried to represent attachments in a similar fashion to the note handling in the export. Those are regular item-members as well, but are represented as dedicated items with a parent relation within the export. I'm not sure what the primary intention was, but maybe one of the developers can step in there.

wetneb commented 5 years ago

@dstillman any preference about the desired output for this? Would you merge this if we update the tests?

noctux commented 4 years ago

Any updates on this?

noctux commented 4 years ago

I've now adapted the tests and fixed one minor flaw in the current implementation (not all url-attachments actually have a title). @wetneb: Could you pull the current state from my feature-attachment-urls branch and update this pull-request with it? @dstillman: Would that be enough to get this merged? Or do you see any further problems with this PR?

noctux commented 4 years ago

@wetneb Thanks!

dbolser commented 4 years ago

Any blockers here, or is this just pending a pull? e.g. why hasn't this been pulled?

Thansk

noctux commented 4 years ago

Just out of curiosity: @dstillman: Any new input on this? Either a definite yes or no? Would it help to make this configurable (with a default to false) to make it more acceptable to publically hosted instances or something like that? Do you want changes to be made to the output format?