search

zotero / translators

Zotero Translators
http://www.zotero.org/support/dev/translators
1.28k stars 756 forks source link

Online Translator Tests are currently not working #1356

Closed zuphilip closed 5 years ago

zuphilip commented 7 years ago

The online translator tests are currently not working. As far as I can say this started after @dstillman worked on the translation-server and switched the tests from 4.0 to 5.0.

What are the further plans for the online translator tests? When will they work again?

dstillman commented 7 years ago

Sorry, should be running again now (using current translation-server HEAD, not the 4.0 version in Docker Hub). Various things (like import translators) are still broken in the 5.0 version.

Also it looks like a lot of tests are broken due to data format changes in 5.0, most notably with tags. I'm not totally sure what the situation is there. It looks like tests generally expect just an array of strings, but the 5.0 code is producing a { tag: "foo" } object. That might make sense if it was to allow translators like Zotero RDF to create manual tags and the rest to create automatic (type: 1) tags, but it's not actually producing type: 1 tags (and it would be kind of tedious anyway, since manual tags from translators are the rare exception), so I'll look into this.

dstillman commented 5 years ago

Tests are up again, on a new domain, and in a more stable fashion based on translation-server v2: https://translator-tests.zotero.org

As a reminder, translation-server doesn't run JavaScript, even for the initial page load, unlike the Connector, which uses XHR for subsequent requests but starts with the initial JS-rendered page, so various sites (like, say, zotero.org) won't work. We could consider fixing that, but we can discuss that elsewhere.