search

zotero / translators

Zotero Translators
http://www.zotero.org/support/dev/translators
1.19k stars 743 forks source link

Nature Publishing Group: regression in tag handling #246

Closed simonster closed 12 years ago

simonster commented 12 years ago

Since Embedded Metadata started handling tags, the tags for NPG don't look quite as great. In one of the test, we previously got ["Biochemistry", "Structural biology"], whereas we now get [" Structural biology, Biochemistry"]. We should modify Embedded Metadata to trim tags, and in the case where there's only one comma, we should split them apart in NPG (or else we should modify Embedded Metadata to split the tags in this case).

aurimasv commented 12 years ago

For reference, the related discussion is at #209. Personally, I think a comma separating two keywords is more common than a comma separating lastName, firstName within "keywords" meta tag. I think we should try to split on semicolon and if we can't then split on comma, just like we do with authors. Of course, not splitting on comma can be handled downstream, but once we split it's not easy to reverse.

If we do pass this sort of splitting to individual site translators, however, I have a feeling that we will just end up having the same boilerplate code that will end up messing up the occasional case that looks like Avram's example.

aurimasv commented 12 years ago

This can be closed