search

zotero / translators

Zotero Translators
http://www.zotero.org/support/dev/translators
1.28k stars 758 forks source link

Project Muse automatically download all chapters of a book #2819

Open boan-anbo opened 2 years ago

boan-anbo commented 2 years ago

I was wondering if the Project Muse translator could stop downloading all pdfs attachments for books automatically.

https://github.com/zotero/translators/blob/7aeaea1d12e5e4e139c282e53f9550d64044c224/Project%20MUSE.js#L115

Several reasons for the change (take this book for example):

  1. Some books have Epub format for the entirety of books and the user might not want individual pdf chapters.
  2. Zotfile cannot handle multiple pdfs (each for a chapter) for a single entry of book. This causes only the first pdf to be treated as the default attachment and the others to be handled by Zotero (and saved in a separate Zotero location for instance)
  3. In my personal experience, the user might want to download all the chapters themselves and combine the pdfs before attach the combined pdf to the entry.
  4. This might cause exceeding the download rate set for Project Muse because it's not treated as a Zotero translator collection of items, where the user get to specify which to download. A single click will trigger all pdfs to be downloaded.

So I suggest remove the the functionality for book but keep it for collections for Project Muse journals.

If this is Ok, I can create a PR.

AbeJellinek commented 2 years ago

Sure, please do open a PR.