search

zotero / translators

Zotero Translators
http://www.zotero.org/support/dev/translators
1.19k stars 743 forks source link

Add translator for Public Record Office Victoria #3233

Open wragge opened 5 months ago

wragge commented 5 months ago

New translator for checking. I think it's pretty straightforward as the metadata is all coming from their public API. Thanks!

wragge commented 5 months ago

I think this is ready to go now?

AbeJellinek commented 4 months ago

OK, made a couple nitpicky formatting/regex changes.

A few remaining things:

  1. I'm not sure we want to set the Library Catalog to something containing "API" - that field isn't really used in most citation styles, but it's still a little confusing and not really relevant. The default (the translator label) is fine.
  2. "Download file as PDF" - "Full Text PDF"? For consistency.
  3. Is the manifest useful? We don't normally attach machine-readable-only files in translators. We could put it behind a hidden pref, but it seems to me like the sort of thing that you'd attach manually if you wanted it.
AbeJellinek commented 4 months ago

Oh, and

  1. If we're attaching the PDF, why attach the image? Are the PDFs often very large? (I'm not confident that snapshot: false will prevent a non-text/html attachment from being attached...)