Closed adam3smith closed 2 months ago
Ah, no. What would be the right format? I understand that they like the namespace prefix to be included? So openalex.org/W12345
?
@AbeJellinek I think this should be all set
Hello! @adam3smith
As all OA uses the type "article" for journal articles, conference proceedings and preprints, what do you think about adding the following logic into the JSON translator?
Journal articles will have a
primary_location.source.type
ofjournal
Conference proceedings will have aprimary_location.source.type
ofconference
Preprints or "posted content" will have aprimary_location.version
ofsubmittedVersion
See https://docs.openalex.org/api-entities/works/work-object#type
@quachpas: We'd need some test cases for those, but makes sense to me.
@AbeJellinek you need to revert capitalization for OpenAlex JSON.js. It breaks the tests for the field extra
.
As for a patch, how about this?
```patch
From 8e1c7a396085173a3b52c74bba902f915379c547 Mon Sep 17 00:00:00 2001
From: Pascal Quach
Thanks. Not sure why I did that...
Let me know if it looks good now with the suggested changes!
As far as I can see, I believe it's good to go.
Thank you @quachpas!
This is great, many thanks!
Can I check whether the translator will add the openalex id to the Zotero record?