zotero / translators

Zotero Translators
http://www.zotero.org/support/dev/translators
1.26k stars 750 forks source link

Supplementary Data Download Not Working #3281

Open aidan-gibson opened 6 months ago

aidan-gibson commented 6 months ago

If one has extensions.zotero.translators.attachSupplementary set to True in the Desktop app, and downloadAssociatedFiles true in Firefox Connector Ext, then Firefox should work to also download the supplementary data for the following sources: HighWire 2.0 Nature Publishing Group ScienceDirect Cell Press ACS Publications

(Documented here https://www.zotero.org/support/preferences/hidden_preferences#translator_preferences) (Discussed here https://forums.zotero.org/discussion/21880/supplementary-information)

I disabled all plugins and:

Tried https://www.nature.com/articles/nature10840 via proxy; didn't work, no supplementary data downloaded Tried https://www.cell.com/heliyon/fulltext/S2405-8440(24)04671-1 (open access so no proxy needed); didn't work, no supp data downloaded.

Checked Zotero cloud to see if they're saving there but not in Zotero Desktop; nope, not there either.

Firefox 124.0.1 (64-bit). Fresh install, no other extensions or config changed. macOS Sonoma 14.4 Zotero Desktop 6.0.37 Zotero Firefox Connector Version 5.0.123

I and others view this as a vital feature to Zotero's functionality; not only should the original functionality be restored, but expanded to other sources and Chrome. I am happy to help contribute code to this end, please point me in the right direction.

Thanks!

adam3smith commented 6 months ago

Thanks. This is written into the individual translators, so needs to be manually fixed for those where it used to work and added for any additional ones. The code in the Nature Publishing Group translator would be a good starting point for the relevant preference checks and functions to use -- it likely just needs to get updated to actually grab the supplementary data (but I don't think the functionality overall has been tested for a while, so I won't promise it still works, but would expect it to).