search

zotero / translators

Zotero Translators
http://www.zotero.org/support/dev/translators
1.3k stars 761 forks source link

JSTOR RIS includes EZProxy in URL #3347

Closed owcz closed 2 months ago

owcz commented 3 months ago

For the last month or so, the JSTOR translator has been including EZProxy prefixes in imported URLs. I checked a RIS download and it looks like this is because ezproxy is part of the UR field (e.g., UR - http://www.jstor.org.i.ezproxy.nypl.org/stable/1823178). This is unexpected, since the translator previously stripped this detail to create a canonical URL. Should I add handling to the JSTOR translator or is there another place this is handled in Zotero's proxy handling?

AbeJellinek commented 3 months ago

@adomasven should weigh in here, but if they're putting proxied URLs in the RIS (I can reproduce for the page you linked, at least), we'd want to use ZU.urlToProper() to de-proxify them from the translator.

I think the translation framework assumes that translators won't return items with proxied url fields and doesn't do anything to de-proxify them during post-processing.

AbeJellinek commented 3 months ago

Oh, except no, I'm not getting a proxied URL in the url field when I translate from Firefox, only from Chrome. So I would guess this is a MV3 problem. I'll open a zotero-connectors issue.

AbeJellinek commented 2 months ago

Fixed: https://github.com/zotero/zotero-connectors/pull/498