search

zotero / translators

Zotero Translators
http://www.zotero.org/support/dev/translators
1.3k stars 763 forks source link

Update Crossref REST translator #3359

Closed mrtcode closed 2 months ago

mrtcode commented 2 months ago

I noticed there are some differences in the available data compared to the XML API. For example, fields like ISBN, pages, editors, contributors, and language, etc. can sometimes be missing, but not always. However, this translator performs better with various book-related items.

It was tested with all item types provided by the Crossref API, and each item type is also included in the tests.

All in all, I think it's pretty good now.

The hyphen has been removed from the translator file name to match the actual translator name (there was an issue with Scaffold). I wonder if this could have any negative consequences?

mrtcode commented 2 months ago

To run test with Scaffold detectSearch has to be changed to return true.

dstillman commented 2 months ago

We should set Library Catalog to just "Crossref", not "Crossref REST".

mrtcode commented 2 months ago

We should set Library Catalog to just "Crossref", not "Crossref REST".

Fixed. However, I imagine it will be overridden, as is the case with the XML translator.