feat: Update IMDb.js to add URL to item

zotero / translators

Zotero Translators

http://www.zotero.org/support/dev/translators

1.3k stars 761 forks source link

feat: Update IMDb.js to add URL to item #3385

Open johev09 opened 2 weeks ago

johev09 commented 2 weeks ago

Changes

IMDb.js:

Adding URL to item in scrape(...) method

Notes

This changes populates the URL field when saving a IMDb page to Zotero using Zotero Connector.
Populating the URL makes the Zotero item clickable
Opens IMDb page on double-clicking the Zotoer item.

Testing

Tested on my local machine.
Verified URL is getting populating on saving an IMDb link.

AbeJellinek commented 3 days ago

I don't think this is really correct. We could add a Snapshot attachment, but the URL field is for URLs where full-text (full-film?) content can be found. IMDb is a catalog site akin to a library catalog; we don't add URLs for those.

(I'm also confused about the seemingly unrelated changes to the URL check and XPaths.)