Fix pdf note creation

[yexingsha]

Now that the pspdfkit default note editor is disabled, our own annotation creation screen still doesn't open:

https://github.com/zotero/zotero-android/assets/57771795/7b2c3a1e-4c71-4651-862d-d705424bd0f3

Also, the note icon on pdf is wrong, see iOS for reference

[Dima-Android]

Can you please specify exact steps to reproduce? Do you open the pdf and immediately try to add a note or maybe you do something before that? Also what's the Android OS version on your phone? This is how it should look: https://github.com/zotero/zotero-android/assets/25297619/a6ded69e-f339-4240-a0d3-7150f11bd02c

[yexingsha]

I'm testing in emulator, this happened a few times on both Pixel 3A API 34 and Pixel C API 34.

I can't reproduce it reliably, sometimes it happens when I immediately try to add a note, sometimes it happens after I delete an existing note, but neither of those conditions will guarantee it. What I'm doing is basically: open a pdf -> immediately try to add a note -> if it works, hit "delete annotation" -> exit the pdf -> reopen the same pdf and repeat, until something weird happens.

So far I have reproduced this bug on three different pdfs, this one was downloaded before and has other annotations, another one was also downloaded before but has no other annotation, and yet another one is newly downloaded and has no other annotation. Just takes a lot of tries and luck. Perhaps it's caused by coinciding with syncing?

I also encountered another (perhaps the same?) bug, where a note icon is added to the pdf, but the annotation creation screen still doesn't open:

https://github.com/zotero/zotero-android/assets/57771795/86cd7e17-6ed1-40a8-a512-65434e26e014

[stakats]

Oh, I think i might also have seen this, on my Samsung tablet. On Dec 14, 2023, at 16:46, yexingsha @.***> wrote: I'm testing in emulator, this happened a few times on both Pixel 3A API 34 and Pixel C API 34. I can't reproduce it reliably, sometimes it happens when I immediately try to add a note, sometimes it happens after I delete an existing note, but neither of those conditions will guarantee it. What I'm doing is basically: open a pdf -> immediately try to add a note -> if it works, hit "delete annotation" -> exit the pdf -> reopen the same pdf and repeat, until something weird happens. So far I have reproduced this bug on three different pdfs, this one was downloaded before and has other annotations, another one was also downloaded before but has no other annotation, and yet another one is newly downloaded and has no other annotation. Just takes a lot of tries and luck. Perhaps it's caused by coinciding with syncing? I also encountered another (perhaps the same?) bug, where a note icon is added to the pdf, but the annotation creation screen still doesn't open: https://github.com/zotero/zotero-android/assets/57771795/86cd7e17-6ed1-40a8-a512-65434e26e014

—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you are subscribed to this thread.Message ID: @.***>