search

zotero / zotero-connectors

Chrome, Firefox, Edge, and Safari extensions for Zotero
https://www.zotero.org/download/connectors
Other
507 stars 119 forks source link

Include list of other installed extensions in error report #165

Open dstillman opened 7 years ago

dstillman commented 7 years ago

Possible starting in Firefox 56 (and I think already available in Chrome):

https://blog.mozilla.org/addons/2017/08/10/webextensions-firefox-56/ https://developer.chrome.com/extensions/management#method-getAll

We did this in Zotero for Firefox to identify conflicts.

dstillman commented 7 years ago

Or not, at least in Chrome. This would trigger a permissions warning, so not worth losing users over. If Chrome changes the behavior of upgraded permissions so that extensions stay enabled and you just don't get the permission until approved, we can reconsider.

We should check what Firefox does. If it does something more reasonable, we could add there, where it's more important anyway.

adomasven commented 7 years ago

Apparently there's optional permissions, so we can still go ahead and prompt on report ID submission.

adomasven commented 7 years ago

Optional permissions for 'management' unavailable in Firefox. Waiting for upstream changes

dstillman commented 6 years ago

Seems like we could do this in Chrome for now, at least.

adomasven commented 6 years ago

We could, but then manifest.json won't be compatible with Firefox, since you have to list the optional permissions you intend to request in it. We'd have to split the build process, which I'm hesitant to do.

dstillman commented 6 years ago

We already do that — among other things, we remove the 'applications' property for Chrome builds. The exact change required here depends on what Firefox does if that permission is listed, but I can take care of the build step.

It would be very useful to start including the extensions list in at least some reports.

dstillman commented 6 years ago

Looks like Firefox does the same thing as Chrome for 'applications': complains in about:debugging but otherwise loads. So we could add this and strip it for Firefox builds.

adomasven commented 6 years ago

When I was trying it, Firefox was refusing to load it completely, which is why I didn't go through with it.

adomasven commented 4 years ago

Other extensions interfering with the Connector has not been a problem recently, but we should still look into this for Firefox. Also a user noted that we should be removing the permissions once no longer needed. See https://developer.chrome.com/extensions/permissions