Open dstillman opened 7 years ago
So we can do the first part of this pretty easily. We just need to set .notes = [{ note: noteText }]
on the item that gets sent to /saveItems
. A little tricky since that's in translate.js, but we could pass through a property to translate()
that adds a given note to any items (and we'd only do so on non-multiple
pages).
We could consider adding this to Safari context menu when there is selected text, but Safari does not allow nesting its context items, so we're probably better off to just keep it in the popover.
Meaning you could only get it in Safari if you press and hold on the save button? That doesn't seem very pleasant. I think just displaying it in the context menu on text selection in Safari would be fine.
Safari support added in https://github.com/zotero/zotero-connectors/commit/d45f7626c5a01b5fb5512648ecc3fa035a941266
https://forums.zotero.org/discussion/67103/create-zotero-item-and-note-from-selection-missing-from-z5-standalone
This was a Zotero for Firefox feature — not sure how much use it got, though probably not a lot.
There was also a feature that would add selected text to the open note in Zotero, which I guess would be easy enough to do once we have SSE, and I could see it being pretty useful as an alternative to highlighting webpages (which we used to support in early versions of Zotero).
I'm not sure if either of these are possible on PDFs in the viewer. If so, they'd be more useful (though actual PDF highlighting and ZotFile's extracted annotations (which we want to integrate) seem like a better approach in general).
I don't have strong feelings on either of these, but since they're fx-parity, we should at least track them.