search

zotero / zotero-connectors

Chrome, Firefox, Edge, and Safari extensions for Zotero
https://www.zotero.org/download/connectors
Other
530 stars 124 forks source link

Wrong snapshots saved on Medium #438

Open dstillman opened 1 year ago

dstillman commented 1 year ago

https://forums.zotero.org/discussion/106092/many-titles-have-the-wrong-snapshot

Something about client-side page loads? Not about search results, so I assume not related to https://github.com/zotero/zotero-connectors/commit/eff8f306b64a3965031d2900e75191aa9b41beb7?

adomasven commented 1 year ago

I can reproduce the Medium translator not being detected, but I get correct snapshots.

adomasven commented 1 year ago

I've pushed https://github.com/zotero/zotero-connectors/commit/0c920b2b8f6020d43b9473e2366226596b7ac81b which is not related to this issue, but related to my findings on Medium.com. Unfortunately after it changes the URL it displays a placeholder before rendering the article, which is why the translator does not get detected. If possible, this should be addressed in the translator.

adomasven commented 1 year ago

I did reproduce the singlefile issue once somehow, but cannot get it to occur consistently. But we were saving on the correct page, with the correct URL, in-browser, and singlefile.getPageData() was somehow saving the completely wrong document, as if it had access to the previous page's HTML, which makes no sense as it saves from the live document element. So this is likely not strictly a Zotero bug, and could even be browser-level, but unless we find a way to reliably reproduce it it's going to be hard to troubleshoot or report upstream.