search

zotero / zotero-connectors

Chrome, Firefox, Edge, and Safari extensions for Zotero
https://www.zotero.org/download/connectors
Other
477 stars 118 forks source link

Multiple DOI results not saved in Firefox #447

Closed dstillman closed 4 months ago

dstillman commented 8 months ago

https://forums.zotero.org/discussion/108638/add-all-search-results-via-doi-issue

I can reproduce this.

adomasven commented 8 months ago

While I'm not able to reproduce this consistently, the page is sending a bunch of ZoteroItemUpdated events, which triggers Zotero to rerun detection, upon focusing the page. So I assume that's what's causing issues.

https://github.com/zotero/zotero-connectors/blob/0c920b2b8f6020d43b9473e2366226596b7ac81b/src/common/inject/inject.jsx#L92-L96

I have no actual idea how common the use of ZoteroItemUpdated is in general as it was added before I joined Zotero, but we actually rerun detection if Chrome reports URL change even via history and also our detection code can wait for pages that load progressively via JS, so I would be in favor of removing that completely.

adam3smith commented 8 months ago

I can't speak about the technical side, but for usage: It's not terribly common, but some or the folks most dedicated to make Zotero work use it -- in this case, Zotero wasn't picking up DOIs before they added it.

adomasven commented 4 months ago

Fixed by website admin