Localize strings in select-items dialog

zotero / zotero-connectors

Chrome, Firefox, Edge, and Safari extensions for Zotero

https://www.zotero.org/download/connectors

Other

477 stars 118 forks source link

Localize strings in select-items dialog #449

Closed dstillman closed 7 months ago

dstillman commented 7 months ago

https://groups.google.com/d/msgid/zotero-dev/05c49802-48e8-454b-986d-74de9d826e35n%40googlegroups.com

One of the more prominent user-facing UI components

dstillman commented 7 months ago

This isn't actually working. You have general_cancel for "OK", but it still says "OK". After changing it to general_ok, it still says "OK" rather than "Ok", which you have for the localized string (though that should be "OK" too). Removing value="OK", it says "Submit" in Chrome and "Submit Query" in Firefox.