search

zotero / zotero-connectors

Chrome, Firefox, Edge, and Safari extensions for Zotero
https://www.zotero.org/download/connectors
Other
531 stars 124 forks source link

Connector detects invalid proxy when reloading on login page after switching to institutional network #492

Open AbeJellinek opened 4 months ago

AbeJellinek commented 4 months ago

I've encountered this a couple times when testing translators:

  1. Start on an EZProxy login redirect page, like https://libproxy.berkeley.edu/login?qurl=https://www.proquest.com/archivefinder
  2. Enable a VPN/SOCKS proxy that gives you institutional access
  3. Reload the login page. EZProxy will detect your institutional access and redirect to the qurl page, without any proxy.
  4. The Connector will show a banner prompting you to add %h/%p as a proxy, and Invalid proxy %h/%p: TypeError: parts[1].split(...).pop().match(...) is null will be logged in the Connector error console

Seems like it's detecting the unproxied page as proxied and offering to create a no-op proxy. The prompt probably shouldn't show for no-op proxies / proxies that fail to parse.

adomasven commented 4 months ago

Ah, I've been for someone to reproduce this for a while! Thanks! Will look into fixing it.