search

zotero / zotero-connectors

Chrome, Firefox, Edge, and Safari extensions for Zotero
https://www.zotero.org/download/connectors
Other
530 stars 124 forks source link

Update testrunner for Firefox #517

Closed maxsu closed 3 weeks ago

maxsu commented 3 weeks ago

This patch gets tests running on firefox 131. We install the addon in temporary mode and drop the preference hack.

Issue

Firefox test run fails with

WebDriverError: Could not install add-on

Changes

  1. Install addon in temporary mode
    • Tested in Firefox 131 => fixes issue
  2. Remove broken xpinstall.signatures.required code
    • Tested in Firefox 131 => fix remains stable

Docs

adomasven commented 3 weeks ago

We're not really using this testrunner anymore since running evals has been severely restricted with MV3 (on which the old tests rely heavily) and tests are likely to fail. However since the development of these tests new selenium and browser APIs have been added that would allow to write proper tests automating the browser and testing the plugin for behavior.