search

zotero / zotero-google-docs-integration

32 stars 6 forks source link

Safari support #19

Closed dstillman closed 5 years ago

dstillman commented 5 years ago

Since the Safari connector was finally accepted into the Extensions Gallery, we might as well look into whether Google Docs support works in Safari and, if not, if it's easy to get it working. I believe updates to Gallery extensions are approved more quickly, so we'll probably have a chance to push out at least a couple updates before they stop accepting updates in December 2018 (but we should obviously wait until we're pretty sure we have a stable build before submitting).

Of course, if Google Docs changes after December 2018 in a way that breaks something, we wouldn't be able to do anything to fix it, which makes me a little nervous, but people would still be able to turn off Google Docs integration. That would probably just prevent it from working, not break Google Docs, but we could consider building in a kill switch in the client ping if we were concerned.

dstillman commented 5 years ago

(If it's not easy to get working, it's probably not worth it, but I would expect the Safari connector from the Gallery to remain installable until Safari 13 next fall, and I don't think there's any particular reason we couldn't make this part of a future Safari App Extension, so it'd be nice to support it.)

dstillman commented 5 years ago

Apparently the version of 5.0.41 we submitted has the setting in the prefs — though off by default, I believe, and marked as experimental. But the basics, at least for APA, seem to work.

adomasven commented 5 years ago

Great news! I haven't tested Safari support recently, but I think the current version should just work without issues. Either way, I'll do some testing and report.

adomasven commented 5 years ago

Current version works in safari without modification