search

zotero / zotero-google-docs-integration

32 stars 6 forks source link

Do not show the "please wait" overlay while the citation dialog is open. #58

Open nsrosenqvist opened 3 years ago

nsrosenqvist commented 3 years ago

I find it really inconvenient that the document no longer responds to scroll input while the citation dialog is open. Often I have notes in the document with page numbers, or I might forget where or what I wanted to cite and must then close the dialog, find the reference, and then redo the entire process. When the citation dialog opens, the view scrolls down to where the cursor is adding the entry, and I often can't see the text passage I'm working on. It doesn't help either that it often takes a while for it to open and close.

My suggestion is to either remove the white frame covering the entire document that is capturing the scroll events (while still keeping the overlaid notice message), or even better, simply allow the scroll events to propagate up to the document element (then perhaps also lower the opacity of the white frame so that the text can be seen more easily).

Thanks for considering this issue!

adomasven commented 3 years ago

Do note that all feature requests should be posted on the Zotero Forums. See CONTRIBUTING.md.

The change to scrolling behavior is due to Google Docs switching to canvas rendering of document contents on the backend. However we could probably disable the overlay while the citation dialog is open completely, since technically Zotero does not need exclusive access to the doc at that point.

nsrosenqvist commented 3 years ago

@adomasven oh, sorry about that! This repo didn't have a CONTRIBUTING.md, and I arrived here directly by searching for the git repo, so I assumed this was the way to go about it. My apologies! Thanks for still considering it!