search

zotero / zotero-libreoffice-integration

Zotero LibreOffice integration
https://www.zotero.org/support/libreoffice_writer_plugin_usage
Other
68 stars 30 forks source link

Icons #43

Open bijang opened 5 years ago

bijang commented 5 years ago

Zotero icons need a design overall ideally, to fit hidpi, due to most common icons used by v6.3, to be compatible with the new toolbar/groupbar variations available from v6.2 onwards, and possibly even different designs to fit the most common styles (breeze, colibre, elementary)

rizmut commented 3 years ago

Currently I am the maintainer of official icon theme in LibreOffice, I might give a hand to this request.

rizmut commented 2 years ago

Helo, can I work on this request?

Just curious, where the icon definition is placed? The icons itself are placed under build/oxt/icon. I would like to update them to 24px size instead of 26px

adomasven commented 2 years ago

Helo, can I work on this request?

Do you know how to bundle different icons for different themes in an extension? How does libreoffice icon theming work?

Just curious, where the icon definition is placed?

https://github.com/zotero/zotero-libreoffice-integration/blob/master/build/oxt/Addons_AOO4.xcu#L107-L186

The icons itself are placed under build/oxt/icon. I would like to update them to 24px size instead of 26px

The icons are 26x26px because that's the requirement. I cannot find any official LibreOffice docs on this on the current web and LibreOffice docs have always been nigh-impossible to locate, but here's one place that says so. It doesn't make much sense to me either if you ask me, but that's what the docs said when we last updated the icons ourselves.

bijang commented 2 years ago

Will the new “Add Note” button be added at some point also? I don't have MS Word, but I presume it is already on that platform, Thank you

dstillman commented 2 years ago

@bijang: Add Note is available on all platforms. If you're not seeing it in LO, reinstall the plugin from the Cite preferences. Post to the forums if you're still having trouble.

bijang commented 2 years ago

thank you that's working fine

rizmut commented 2 years ago

Do you know how to bundle different icons for different themes in an extension?

As far as I know, there's no support for extensions to bring different themes currently from within LibreOffice theming mechanism. Another option is extension makers who provide the option to change the theme, but this means adding a new workload to them How does libreoffice icon theming work?

I have zero understanding about code, so here I can not explain much. But I can bring anyone who interested against the topic to the right person.

The icons are 26x26px because that's the requirement. I cannot find any official LibreOffice docs on this on the current web and LibreOffice docs have always been nigh-impossible to locate, but here's one place that says so. It doesn't make much sense to me either if you ask me, but that's what the docs said when we last updated the icons ourselves.

26px x26px size was "official" icon theme called Galaxy from Sun Microsystem era, the LibreOffice team currently agrees to use 24px as it's standard size in FreeDesktop. But yea, so unfortunate no official docs here.

adomasven commented 2 years ago

As far as I know, there's no support for extensions to bring different themes currently from within LibreOffice theming mechanism.

That was my understanding too.

Another option is extension makers who provide the option to change the theme, but this means adding a new workload to them

I'm afraid we're not interested in it if it requires separate releases.

fitojb commented 2 years ago

The icons are 26x26px because that's the requirement

It was in the Galaxy days, but we have dropped that many years ago, and I changed the Large icons to 24 instead in https://github.com/libreoffice/core/commit/bea44e5c1b982d05314b72452b94fe288071a496

adomasven commented 2 years ago

@fitojb Are there any up-to-date docs for LibreOffice available somewhere that document modern plugin development?

fitojb commented 2 years ago

@adomasven Have you looked at https://wiki.documentfoundation.org/Development/Extension_Development ? If you’re missing something in particular, please make note of it on the talk page or send questions to the mailing list libreoffice@lists.freedesktop.org

raffaem commented 2 years ago

Currently I am the maintainer of official icon theme in LibreOffice, I might give a hand to this request.

@rizmut if you can work on it, I will PR here to add them :)

rizmut commented 2 years ago

Oh yes the work is on progress

@rizmut if you can work on it, I will PR here to add them :)

rizmut commented 2 years ago

zotero-colibre.zip This is my work. For large size, I set 24px instead of 26px to match the latest convention changes. Actually, it still needs an extra large size of 32px. Please let me know if that size would like to be added too.

raffaem commented 2 years ago

I got lost.

Relevant files seem to be in ./build/oxt/icons.

They are not split by LibreOffice theme? So there is the same set of icons for all possible LibreOffice theme?

How plugin icons are supposed to be integrated with the main theme?

Shouldn't this be managed at the theme-level, instead of at the plugin-level?

raffaem commented 2 years ago

zotero-colibre.zip This is my work. For large size, I set 24px instead of 26px to match the latest convention changes. Actually, it still needs an extra large size of 32px. Please let me know if that size would like to be added too.

image

It looks really nice and integrates nicely with the overall colibre theme.

Although I probably would have colored the "Refresh" button in blue, but that's just taste 😁

raffaem commented 2 years ago

@rizmut I don't understand what setDocPrefs_24-a is for. It seems it's not defined in the .xcu files?

rizmut commented 2 years ago

@rizmut I don't understand what setDocPrefs_24-a is for. It seems it's not defined in the .xcu files?

It's just a variation to choose. Either you go with setDocPrefs_24-a or go with setDocPrefs_24

raffaem commented 2 years ago

@rizmut I don't understand what setDocPrefs_24-a is for. It seems it's not defined in the .xcu files?

It's just a variation to choose. Either you go with setDocPrefs_24-a or go with setDocPrefs

Ok, I went with the latter.

I PRed this as promised :D

raffaem commented 2 years ago

zotero-colibre.zip This is my work. For large size, I set 24px instead of 26px to match the latest convention changes. Actually, it still needs an extra large size of 32px. Please let me know if that size would like to be added too.

Hi,

upstream is not interested in my PR (see here).

I agree it's better to have the icons of the extensions change automatically when the user switches theme inside LibreOffice. But this seems not possible with LibreOffice, and I think that we have what we have, and we need to live along with it :)

So I published the extension with your icons bundled on my fork.

If you ever make new icons for new themes, just open an issue there.

It should be trivial to add new icons :)

hydroEng commented 2 years ago

Ah, what a shame, these icons look amazing @rizmut. Maybe they will be upstreamed in the future 🙏

rizmut commented 1 year ago

Hi,

upstream is not interested in my PR (see here).

I agree it's better to have the icons of the extensions change automatically when the user switches theme inside LibreOffice. But this seems not possible with LibreOffice, and I think that we have what we have, and we need to live along with it :)

Just wondering why upstream reject all of the PR? I means at least incorporating one of icon theme will not be a huge problem for them.

But thank a bunch for your PR. I am really too excited to add more icon themes if proper support exists.