zotero / zotero-standalone-build

Zotero client build utility
https://www.zotero.org/support/dev/client_coding/building_the_standalone_client
Other
119 stars 98 forks source link

fx-compat: Apple Silicon source build can't load Mac Word dylib #103

Closed dstillman closed 1 year ago

dstillman commented 2 years ago

The Apple Silicon part of the binary seems to be hardened and can't load an unsigned dylib:

code signature in [dylib] not valid for use in process: Trying to load an unsigned library

The Intel part of the binary doesn't seem to be affected, so loading under Rosetta with arch -arch x86_64 works.

We want to keep the hardening, so we should look into either 1) signing the dylib in Git or 2) signing source builds with Zotero's real cert. In theory (1) would just be committing the version from a real build. Need to confirm that that works in a source build.

(If we go with (1), our build process would still re-sign, so if we messed up and forgot to rebuild it before a cert expired it would only affect Apple Silicon source builds.)

dstillman commented 1 year ago

Fixed by https://github.com/zotero/zotero-standalone-build/commit/b03a43fcfe8c7483812e2d0291c241eab3e7261c